Skip to content

NixOS: support dry activation#56

Closed
veehaitch wants to merge 3 commits intoryantm:mainfrom
veehaitch:dry-activate
Closed

NixOS: support dry activation#56
veehaitch wants to merge 3 commits intoryantm:mainfrom
veehaitch:dry-activate

Conversation

@veehaitch
Copy link
Copy Markdown
Contributor

@veehaitch veehaitch commented Sep 10, 2021 •
edited
Loading

An attempt to address #54 / #55. Unfortunately, the dependency of agenixRoot on the specialfs activation script prevented me from fixing the issue entirely. The specialfs activation script does not (yet) support dry activation. Ideally, we would add dry activation support for specialfs upstream.

Also fixed an f-string related issue with the integration test. I didn't bother to add proper dry activation support for the installSSHHostKeys test.

@ryantm
Copy link
Copy Markdown
Owner

ryantm commented Sep 10, 2021 •
edited
Loading

It would be nice to make the dry-activate messages more informative:

  1. decryption fails:

    RED COLOR [agenix] dry-activate: failed to decrypt ${secretType.file} for path ${path}

    Ideally, it would also say why it failed to decrypt. Like is it missing the decryption key, or did it just not decrypt?

  2. decryption succeeds:

    [agenix] dry-activate: decrypted ${secretType.file} for path ${path}

ryantm
ryantm reviewed Sep 10, 2021
View reviewed changes
@ryantm ryantm mentioned this pull request Sep 10, 2021
Merged
@veehaitch veehaitch force-pushed the dry-activate branch 2 times, most recently from 7c7dd72 to bbacf56 Compare September 14, 2021 14:22
@veehaitch
Copy link
Copy Markdown
Contributor Author

veehaitch commented Sep 14, 2021

Tested with NixOS/nixpkgs@b3d047d

@veehaitch veehaitch marked this pull request as ready for review September 14, 2021 15:12
@veehaitch
Copy link
Copy Markdown
Contributor Author

veehaitch commented Sep 14, 2021

It would be nice to make the dry-activate messages more informative:

While I still agree that this might be a useful addition, I'm hesitating to make the bash code any more complex. Feel free to add any commits to the branch @ryantm.

@veehaitch
Copy link
Copy Markdown
Contributor Author

veehaitch commented Jan 3, 2022

I don't think this PR is relevant anymore, apart from 2f1666b which is still an issue, as far as I can tell.

@veehaitch veehaitch closed this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryantm ryantm ryantm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veehaitch @ryantm